Fix corner cutting of pointsToAvoid#100
Open
robbeman wants to merge 2 commits intoprettymuchbryce:masterfrom
Open
Fix corner cutting of pointsToAvoid#100robbeman wants to merge 2 commits intoprettymuchbryce:masterfrom
pointsToAvoid#100robbeman wants to merge 2 commits intoprettymuchbryce:masterfrom
Conversation
To prevent corner cutting through obstacles
Owner
|
This makes sense to me. Do you mind adding a new unit test which succeeds with this change, but would fail previously? |
robbeman
changed the title
pointsToAvoid
Author
|
I've added the unit test. When commenting out my previous change it will fail by finding a path through the corners of the points marked to avoid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When corner cutting is enabled it was still possible to cut corners of points to avoid. Checking
pointsToAvoidinisTileWalkableprevents cutting through these corners.Not 100% sure if this behaviour is appropriate in all situations or if this should become a separate setting?